Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Fix check failure RAY_CHECK(it != current_tasks_.end()); #47659

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Sep 13, 2024

Why are these changes needed?

The check failure can happen under the following sequence of events:

  1. An async or threaded actor is launched.
  2. An actor task is submitted.
  3. Actor task is received by the actor and is being executed. The task_id is added to CoreWorker.current_tasks_.
  4. A transient network error happens and caller retries the actor task.
  5. The second attempt of the actor task is received by the actor and is being executed.
  6. The first attempt of the actor task finishes and the task_id is removed from CoreWorker.current_tasks_.
  7. The second attempt of the actor task finishes and the check failure happens when we try to erase the same task_id from CoreWorker.current_tasks_ again:
auto it = current_tasks_.find(task_spec.TaskId());
RAY_CHECK(it != current_tasks_.end());
current_tasks_.erase(it);

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
This reverts commit 2acc718.
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Sep 19, 2024
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jjyao jjyao changed the title [Core] Detect old client [Core] Fix check failure RAY_CHECK(it != current_tasks_.end()); Sep 22, 2024
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Copy link
Contributor

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the approach lgtm. lmk when I can review the PR!

@@ -65,7 +66,12 @@ def print_logs(self):
print(content.decode())


gcs_network = network(driver="bridge")
ipam_config = docker.types.IPAMConfig(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you comment how this works? (how the poor networking thing works. how often it happens etc.)

Btw, this is very nice to have such config.. will be very useful for unit test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants